fix: Fall back to InternalServerError when error view rendering fails #23177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents navigation corruption when error view's parent layout throws an exception during afterNavigation by catching the exception and rendering InternalServerError as fallback. Fixes #22146
|
Artur-
commented
Jan 12, 2026
| @Override | ||
| public void afterNavigation(AfterNavigationEvent event) { | ||
| events.add(event); | ||
| if (event.getLocation().getPath().equals("error")) { |
Member
Author
There was a problem hiding this comment.
Suggested change
| if (event.getLocation().getPath().equals("error")) { | |
| if (true) { |
Contributor
There was a problem hiding this comment.
doesn't need the if at all. Can just throw the exception.
caalador
reviewed
Jan 13, 2026
Comment on lines
+309
to
+314
| // Error view threw an exception - fall back to | ||
| // InternalServerError | ||
| LoggerFactory.getLogger(Router.class).error( | ||
| "Exception occurred while rendering error view for '{}'. " | ||
| + "Falling back to InternalServerError.", | ||
| location.getPath(), errorHandlingException); |
Contributor
There was a problem hiding this comment.
The original exception should also be logged as now it will disappear and only the exception failing the exception view rendering is logged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents navigation corruption when error view's parent layout throws an exception during afterNavigation by catching the exception and rendering InternalServerError as fallback.
Fixes #22146