Remove the signal factory abstraction #23176
Merged
+0
−398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The factory interface makes sense only with IOC to inject an implementation without caring about what implementation that is. We now only support using through the `IN_MEMORY_SHARED` constant which defeats the purpose since you're then anyways referencing a specific implementation throughout application code. What we should really do is to provide the in-memory factory as a Spring/CDI bean by default if no other factory bean is defined in the application. But at the same time, there's little point in doing that now before we have any meaningful alternative implementation to use so that we could verify that it actually works to just swap out the implementation without additional changes. Because of this, we should remove the abstraction now and then add it back later when we add clustering support.
|
Test Results1 310 files - 1 1 310 suites - 1 1h 13m 33s ⏱️ - 1m 17s Results for commit 6363690. ± Comparison against base commit cda083a. This pull request removes 15 tests. |
tltv
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The factory interface makes sense only with IOC to inject an implementation without caring about what implementation that is. We now only support using through the
IN_MEMORY_SHAREDconstant which defeats the purpose since you're then anyways referencing a specific implementation throughout application code.What we should really do is to provide the in-memory factory as a Spring/CDI bean by default if no other factory bean is defined in the application. But at the same time, there's little point in doing that now before we have any meaningful alternative implementation to use so that we could verify that it actually works to just swap out the implementation without additional changes. Because of this, we should remove the abstraction now and then add it back later when we add clustering support.