refactor: Move frontend build classes to flow-build-tools #23161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
changed the title
The idea with flow-build-tools is that it contains classes only used by vaadin-dev-server and the plugins. It is ok for flow-build-tools to depend on flow-server but not the other way around
Artur-
force-pushed
the
reverse-build-tool-deps
branch
from
60451ca to
7b10f2a
Compare
mcollovati
requested changes
Jan 12, 2026
flow-plugins/flow-maven-plugin/src/it/frontend-scanner-tuning-project/pom.xml
Outdated
Show resolved
Hide resolved
Collaborator
|
I don't remember if it has already been discussed, but should |
… plugin ITs Make flow-build-tools dependency provided and optional in integration tests to prevent it from being picked up by ClassFinder as a project dependency. This better simulates real application projects which don't typically depend on build tools directly. Changes: - Add provided+optional scope to 6 ITs that implement TypeScriptBootstrapModifier: - classfinder-lookup - resources-from-project - deps-with-classifier-dups-project - plugin-pinned-deps-project - commercial-banner-build - ignore-maven-deps-from-project - Remove flow-build-tools dependency entirely from frontend-scanner-tuning-project (doesn't implement TypeScriptBootstrapModifier and doesn't need the dependency) All ITs pass successfully with these changes.
Member
Author
Done in #23167 |
Remove TypeScriptBootstrapModifier implementations and flow-build-tools dependencies from integration tests that don't actually test or verify the modifier functionality. This makes the ITs better simulate real application projects that don't implement build-time interfaces. Changes to 5 ITs (resources-from-project, deps-with-classifier-dups-project, plugin-pinned-deps-project, commercial-banner-build, ignore-maven-deps-from-project): - Remove ProjectFlowExtension.java implementations - Remove flow-build-tools dependency entirely Changes to classfinder-lookup IT: - Remove project-level ProjectFlowExtension.java - Remove flow-build-tools dependency - Update verify.bsh to test only addon-level TypeScriptBootstrapModifier - Update description to clarify it tests addon modifier discovery - Now simulates a pure application project that only consumes modifiers from addons This completes the Phase 2 cleanup, making all ITs realistic simulations of either application projects (no TypeScriptBootstrapModifier) or the addon discovery mechanism (flow-addon provides the modifier).
mcollovati
reviewed
Jan 12, 2026
...ven-plugin/src/it/classfinder-lookup/src/main/java/com/vaadin/test/ProjectFlowExtension.java
Outdated
Show resolved
Hide resolved
Member
Author
|
I think this is good enough as a starter. There are still files in |
|
mcollovati
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea with flow-build-tools is that it contains classes only used by vaadin-dev-server and the plugins. It is ok for flow-build-tools to depend on flow-server but not the other way around
Fixes #22238
Fixes #22778