Skip to content

Conversation

@Artur-
Copy link
Member

@Artur- Artur- commented Jan 9, 2026

No description provided.

@Artur- Artur- requested a review from caalador January 9, 2026 11:35
@Artur- Artur- changed the title chore: Remove dependency on node installer from platform detector refactor: Remove dependency on node installer from platform detector Jan 9, 2026
@github-actions github-actions bot added the +1.0.0 label Jan 9, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Test Results

1 309 files   - 1  1 309 suites   - 1   1h 14m 38s ⏱️ + 1m 4s
9 287 tests ±0  9 219 ✅ ±0  68 💤 ±0  0 ❌ ±0 
9 734 runs  +8  9 658 ✅ +7  76 💤 +1  0 ❌ ±0 

Results for commit c3828ae. ± Comparison against base commit fae00b7.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
com.vaadin.flow.server.frontend.installer.PlatformTest ‑ testGuess_whenOsIsAnythingOtherThanLinuxAlpineRelease_officialNodeDownloadPathReturned
com.vaadin.flow.server.frontend.installer.PlatformTest ‑ testGuess_whenOsIsLinuxAndAlpineReleaseFileDoesNotExist_officialNodeDownloadPathReturned
com.vaadin.flow.server.frontend.installer.PlatformTest ‑ testGuess_whenOsIsLinuxAndAlpineReleaseFileExists_unofficialNodeDownloadPathReturned
com.vaadin.flow.server.frontend.installer.NodeInstallerTest ‑ testGuess_whenOsIsAnythingOtherThanLinuxAlpineRelease_officialNodeDownloadPathReturned
com.vaadin.flow.server.frontend.installer.NodeInstallerTest ‑ testGuess_whenOsIsLinuxAndAlpineReleaseFileDoesNotExist_officialNodeDownloadPathReturned
com.vaadin.flow.server.frontend.installer.NodeInstallerTest ‑ testGuess_whenOsIsLinuxAndAlpineReleaseFileExists_unofficialNodeDownloadPathReturned

@caalador caalador merged commit b133f93 into main Jan 9, 2026
31 checks passed
@caalador caalador deleted the break-node-dep branch January 9, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants