Skip to content

fix: do not leak internally used dependencies to actual apps, not even as optionals (#23011) (CP: 25.0) #23152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vaadin-bot merged 1 commit into from
Jan 9, 2026
Merged

fix: do not leak internally used dependencies to actual apps, not even as optionals (#23011) (CP: 25.0) #23152

vaadin-bot merged 1 commit into from
Jan 9, 2026

Conversation

@vaadin-bot
Copy link
Collaborator

@vaadin-bot vaadin-bot commented Jan 9, 2026

This PR cherry-picks changes from the original PR #23011 to branch 25.0.

Original PR description

Uses shade plugin to pull in some transitive dependencies to internal "flow-build-util" module. Although they are not ending up to the actual production artifact, they lower the DX as in IDE it may appear one has them evailable.

Fixes #23007

@mstahv @vaadin-bot
fix: do not leak internally used dependencies to actual apps, not eve…
f5ac9ef 
…n as optionals (#23011)

Uses shade plugin to pull in some transitive dependencies to internal "flow-build-util" module. Although they are not ending up to the actual production artifact, they lower the DX as in IDE it may appear one has them evailable.

Fixes #23007
@vaadin-bot
Copy link
Collaborator Author

vaadin-bot commented Jan 9, 2026

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) January 9, 2026 08:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

github-actions bot commented Jan 9, 2026 •
edited
Loading

Test Results

1 310 files  1 310 suites   1h 16m 41s ⏱️
9 276 tests 9 208 ✅ 68 💤 0 ❌
9 736 runs  9 661 ✅ 75 💤 0 ❌

Results for commit f5ac9ef.

♻️ This comment has been updated with latest results.

@vaadin-bot vaadin-bot merged commit 220506c into 25.0 Jan 9, 2026
47 of 49 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-23011-to-25.0-1767947122836 branch January 9, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees

No one assigned

Labels

+0.0.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vaadin-bot @vaadin-review-bot @mstahv