fix: make StyleSheetHotswapper registerd listener serializable (#23150) (CP: 25.0) #23151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StyleSheetHotswapper registers a UIInitListener and a AfterNavigationListener when it gets initialized. However, lambdas are capturing the hotswapper instance that is not serializable and furthermore keeps a reference to VaadinService. This change refactors the listeners so that they will not capture the StyleSheetHotswapper instance. Fixes #23123
vaadin-review-bot
approved these changes
Jan 9, 2026
Collaborator
Author
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot] |
|
Test Results1 310 files 1 310 suites 1h 15m 7s ⏱️ Results for commit 379104d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes from the original PR #23150 to branch 25.0.
Original PR description