Skip to content

Conversation

@caalador
Copy link
Contributor

@caalador caalador commented Jan 8, 2026

Change from webpush-jwt-jose4j
to com.interaso.webpush

@github-actions github-actions bot added the +0.1.0 label Jan 8, 2026
@vaadin-bot vaadin-bot added +0.0.1 and removed +0.1.0 labels Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Test Results

1 307 files  ±0  1 307 suites  ±0   1h 15m 30s ⏱️ + 1m 39s
9 270 tests ±0  9 202 ✅ ±0  68 💤 ±0  0 ❌ ±0 
9 730 runs  +4  9 654 ✅ +4  76 💤 ±0  0 ❌ ±0 

Results for commit 5257c34. ± Comparison against base commit 3d0f854.

♻️ This comment has been updated with latest results.

Change from webpush-jwt-jose4j
to com.interaso.webpush
@caalador caalador force-pushed the issues/update-webpush-library branch from 10c4411 to 3bf9b88 Compare January 8, 2026 09:29
@github-actions github-actions bot added +1.0.0 and removed +0.0.1 labels Jan 8, 2026
@caalador caalador marked this pull request as ready for review January 8, 2026 10:30
@github-actions github-actions bot added +0.0.1 and removed +1.0.0 labels Jan 8, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

@caalador caalador added target/24.9 target/25.0 Cherry-pick to 25.0 branch labels Jan 8, 2026
@mcollovati mcollovati self-requested a review January 8, 2026 11:42
Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works fine.
A bit unfortunate that we need the kotlin stdlib dependency.

@caalador
Copy link
Contributor Author

caalador commented Jan 8, 2026

Tested locally and works fine. A bit unfortunate that we need the kotlin stdlib dependency.

It is. Also that there is only a release using an old version of it in the dependency.

@mcollovati
Copy link
Collaborator

This change is marked as a feature, so I wonder if it is OK to backport.
Actually, it seems an internal implementation change, so maybe it is fine, even if it brings in an additional dependency.

@caalador
Copy link
Contributor Author

caalador commented Jan 9, 2026

Also it removes 2 problematic dependencies and the archived old implementation that has been used so far.
Problematic in that they are from the old implementation.

@mcollovati mcollovati merged commit bec101d into main Jan 9, 2026
31 checks passed
@mcollovati mcollovati deleted the issues/update-webpush-library branch January 9, 2026 06:13
vaadin-bot pushed a commit that referenced this pull request Jan 9, 2026
Change from webpush-jwt-jose4j
to com.interaso.webpush
@vaadin-bot
Copy link
Collaborator

Hi @caalador and @mcollovati, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick bec101d
error: could not apply bec101d... feat: Move to com.interaso.webpush (#23136)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vaadin-bot added a commit that referenced this pull request Jan 9, 2026
Change from webpush-jwt-jose4j
to com.interaso.webpush

Co-authored-by: caalador <[email protected]>
caalador added a commit that referenced this pull request Jan 9, 2026
Change from webpush-jwt-jose4j
to com.interaso.webpush
mcollovati pushed a commit that referenced this pull request Jan 9, 2026
Change from webpush-jwt-jose4j
to com.interaso.webpush
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 25.1.0-alpha1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants