feat(FrontendTools): Add support for custom node folder #23124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NodeResolver - Add nodeFolder configuration option to specify custom node installation directory - Consolidate duplicate node/npm resolution logic into reusable methods - Extract normalizeVersion() helper to eliminate duplicate version normalization - Add findNpmCliScript() to unify npm-cli.js lookup across all resolution paths - Add tryResolveFromExecutable() as generic resolution method - Remove redundant getGlobalNpmCliScript(), getCustomFolderNpmCliScript(), getNpmCliScriptPath() - Reduce code duplication by ~50-60 lines This improves maintainability and makes it easier to add new node resolution strategies in the future.
caalador
requested changes
Jan 8, 2026
flow-plugins/flow-plugin-base/src/main/java/com/vaadin/flow/plugin/base/BuildFrontendUtil.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/Constants.java
Outdated
Show resolved
Hide resolved
flow-server/src/test/java/com/vaadin/flow/server/frontend/FrontendToolsTest.java
Show resolved
Hide resolved
…tendToolsTest.java Co-authored-by: caalador <[email protected]>
|
caalador
approved these changes
Jan 8, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
Adds a `nodeFolder` configuration option to specify custom node installation directory. This directory is always used if specified For #23119
vaadin-bot
added a commit
that referenced
this pull request
Jan 8, 2026
) Adds a `nodeFolder` configuration option to specify custom node installation directory. This directory is always used if specified For #23119 Co-authored-by: Artur Signell <[email protected]>
Collaborator
|
Unfortunately, late on the party here. I guess the new property should be added also as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
nodeFolderconfiguration option to specify custom node installation directory. This directory is always used if specifiedFor #23119