feat: add HasEnabled::bindEnabled #23107
Merged
+687
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds void bindEnabled(Signal<Boolean>) method to HasEnabled and Element. Introduces new Node Feature SignalBindingFeature that stores signal and registration in a Map. Only bindEnabled initializes the feature to keep memory consumption optimal when binding is not used. Fixes: #23035
platosha
requested changes
Jan 2, 2026
flow-server/src/test/java/com/vaadin/flow/dom/ElementBindEnabledTest.java
Show resolved
Hide resolved
…edTest.java Co-authored-by: Anton Platonov <[email protected]>
heruan
previously approved these changes
Jan 8, 2026
Member
heruan
left a comment
heruan
left a comment
There was a problem hiding this comment.
The new binding and enabling logic meet the requirements, test coverage is thorough and documentation is clear.
|
heruan
approved these changes
Jan 9, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.1.0-alpha1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds void bindEnabled(Signal) method to HasEnabled and Element. Introduces new Node Feature SignalBindingFeature that stores signal and registration in a Map. Only bindEnabled initializes the feature to keep memory consumption optimal when binding is not used.
Fixes: #23035