feat: Extend WebPushMessage with the custom settings #20304
Draft
+47
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshabarov
force-pushed
the
add-more-options-to-webpush
branch
from
30e4ad4
to
0fa84bf
Compare
|
To note: I'm working on figuring out how can we provide an API for adding action listener, else than asking to extend the service worker (sw.js). Also this needs some testing on mobile. |
tepi
reviewed
Oct 30, 2024
| * @param options any Serializable Java Object representing custom settings that you want to apply to the notification | ||
| * @see <a href=https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/showNotification#parameters</a> | ||
| */ | ||
| public WebPushMessage(String title, Serializable options) { |
There was a problem hiding this comment.
Should we consider providing a proper java class / record for the options instead of just Serializable?
There was a problem hiding this comment.
The reason why I didn't add a class for options if because otherwise we should extend or modify it each time when the browser API changed. IMO it's better to decouple the Java API from the browser API that way.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an API to set custom options as described in https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/showNotification#parameters
Fixes #20285
Type of change
Checklist
Additional for
Featuretype of change