Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: vertical layout example improvements #3975

Merged
merged 1 commit into from
Dec 4, 2024
Merged

refactor: vertical layout example improvements #3975

merged 1 commit into from
Dec 4, 2024

Conversation

sissbruecker
Copy link
Contributor

  • Simplify theme variant examples to show both versions, with and without variant, at once
  • Hide spacing sizes toggle example, remove unused implementations of the example
  • Remove explicit height from layouts, if adding spacing, padding margin results in a different size, why not show that

Closes #3957

@github-actions github-actions bot added the Language unchecked English language check has not been done label Dec 3, 2024
@sissbruecker sissbruecker removed the Language unchecked English language check has not been done label Dec 4, 2024
@sissbruecker sissbruecker merged commit 1fa6dc5 into latest Dec 4, 2024
4 of 5 checks passed
@sissbruecker sissbruecker deleted the refactor/vertical-layout-example-improvements branch December 4, 2024 05:58
@web-padawan web-padawan removed their request for review December 4, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify dynamic samples in HL and VL docs
2 participants
@sissbruecker @DiegoCardoso