feat: Document @Layout #3618
Merged
feat: Document @Layout #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation on using `@Layout` auto layouting in Flow and using server side layout for Hilla views.
github-actions
bot
added
the
Language unchecked
russelljtdyer
added
Language checking
russelljtdyer
added
Language checked
mshabarov
requested changes
Aug 30, 2024
mshabarov
requested changes
Aug 30, 2024
There was a problem hiding this comment.
These two articles should mention that officially the auto main layout is implied to be either in React (Hilla) or in Java (Flow), not both.
We can admit that both layouts are possible with some efforts, e.g. by wrapping React layout into Flow component, but at the moment it can be undocumented feature.
Otherwise looks good to me, can approve.
mshabarov
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation on using
@Layoutauto layouting inFlow and using server side
layout for Hilla views.