-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Popover documentation and live examples #3587
Conversation
0668c4c
to
6d5326d
Compare
Vale complains about some words e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropdown field example
- Missing aria-label
- Doesn't open on focus
- Closes on selections except on to-field?
User Menu
- Doesn't open on kbd-click
Looks like we have a problem with Reported vaadin/web-components#7652 and updated the description to only use "click" for now. |
46b276a
to
8b3f860
Compare
This is problematic as we don't have "keyboard click" logic |
d768ab4
to
5865777
Compare
Rebased and updated the "drop-down field" example to also open on focus in addition to click. |
Co-authored-by: Rolf Smeds <[email protected]>
29eb9db
to
dab9c77
Compare
Added Popover documentation and live examples based on the document.