Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FUSS #9502

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

raulillo82
Copy link
Contributor

What does this PR change?

Add support for a new distribution into Uyuni, FUSS (which should be valid for both FUSS Server or FUSS Client).

GUI diff

A new distribution will exist.

  • DONE

Documentation

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: It's a 100% clone of Debian 12, no tests needed.

  • DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@@ -571,6 +571,10 @@
"venv-salt-minion",
]

PKGLISTFUSS12 = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you reuse PKGLISTDEBIAN12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did not want to add anything other than the Salt Bundle to new OS's, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, but the other things maybe needed in very basic debian installations as maybe they are not installed by default in such cases, and that could be the reason they're there... and could be needed for FUSS12 as well.

@@ -2077,6 +2081,12 @@
"DEST": DOCUMENT_ROOT + "/pub/repositories/raspbian/12/bootstrap/",
"TYPE": "deb",
},
"fuss-12-amd64-uyuni": {
"BASECHANNEL": "fuss-12-pool-amd64-uyuni",
"PKGLIST": PKGLISTFUSS12,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said above.

base_channels = fuss-12-pool-amd64-uyuni
repo_url = http://deb.debian.org/debian/dists/bookworm-backports/main/binary-amd64/

[fuss-12-custom-main-amd64-uyuni]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they call it custom on their side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know how to call it, otherwise the name was the same than the base channel. Open to suggestions...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the name of the file that has it? Or what does the doc says when talking about this repo?

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few additional notes from my side

@@ -0,0 +1 @@
- Add FUSS 12 repositories
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add FUSS 12 repositories
- Add Free Upgrade in South Tyrol's Schools (FUSS) 12 repositories

@@ -0,0 +1 @@
- Add bootstrap repository definitions for FUSS 12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add bootstrap repository definitions for FUSS 12
- Add bootstrap repository definitions for Free Upgrade in South Tyrol's Schools (FUSS) 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants