Do not use postgres extensions dblink and pgcrypto #9367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadvornik
requested review from
witekest,
mcalmer,
mbussolotto,
cbosdo and
aaannz
aaannz
previously approved these changes
Oct 15, 2024
mcalmer
previously approved these changes
Oct 15, 2024
mbussolotto
previously approved these changes
Oct 15, 2024
rjmateus
reviewed
Oct 15, 2024
cbosdo
previously approved these changes
Oct 16, 2024
Comment on lines
32
to
33
| if [[ "$s" == *oracle ]]; then | ||
| db="oracle" |
There was a problem hiding this comment.
Can't we kick those 2 lines out?
There was a problem hiding this comment.
Whole schema/sm-specific-schema-patches seems to be obsolete and can be dropped, IMHO. It has not been touched since 2018. But that is for another PR.
There was a problem hiding this comment.
Yes, this was needed when spacewalk had incompatible changes compared to SUMA and we had to copy them again and again over. We can remove this
|
I saw no upgrade script... is that intended? How would that fly with upgrades? |
nadvornik
dismissed stale reviews from cbosdo, mbussolotto, mcalmer, and aaannz
via
648a7cf
nadvornik
force-pushed
the
drop_pg_ext
branch
from
15efb4a
to
648a7cf
Compare
Fixed. |
nadvornik
requested review from
mbussolotto,
mcalmer,
rjmateus,
cbosdo and
aaannz
aaannz
approved these changes
Oct 17, 2024
rjmateus
reviewed
Oct 17, 2024
| -- granted to use or replicate Red Hat trademarks that are incorporated | ||
| -- in this software or its documentation. | ||
|
|
||
| create or replace function pg_dblink_exec(in_sql in varchar) returns void as |
There was a problem hiding this comment.
Should we also remove this function from the upgrade script?
mcalmer
approved these changes
Oct 17, 2024
cbosdo
reviewed
Oct 17, 2024
| -- granted to use or replicate Red Hat trademarks that are incorporated | ||
| -- in this software or its documentation. | ||
|
|
||
| create or replace function pg_dblink_exec(in_sql in varchar) returns void as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR drops postgres extensions dblink and pgcrypto. This makes use of external database easier.
The extensions seem to be no longer used.
pgcrypto is not used since #8045
dblink is used in function pg_dblink_exec. This function is never called.
GUI diff
No difference.
Documentation
Test coverage
No tests: already covered
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/25363
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!