Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version update checker #9201

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rjpmestre
Copy link
Contributor

@rjpmestre rjpmestre commented Aug 22, 2024

What does this PR change?

In previous versions we had a feature to show a notification when there is a new maintenance update existed.
This relied on zypper's built-in package update checks. However, this is no longer viable for containerized versions.

It was decided the best alternative was to parse the online release notes. To streamline the parsing process across both uyuni and suma, we'd opted to include a specific HTML element—a with the id "current_version"—embedded within the release notes.
This element will contain the current stable version, formatted as follows:

...
<h1>Stable version <span id="current_version">2024.07</span></h1>
...

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Unit tests were added

  • DONE

Links

Issue(s): # https://github.com/SUSE/spacewalk/issues/24552

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9201/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9201/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

Suggested tests to cover this Pull Request

@rjpmestre rjpmestre force-pushed the um_new-maintanance-update-notification branch 3 times, most recently from 171ee05 to 13a5df0 Compare August 22, 2024 13:29
@rjpmestre rjpmestre requested review from aaannz and admd August 22, 2024 13:57
aaannz
aaannz previously approved these changes Aug 22, 2024
Copy link
Contributor

@aaannz aaannz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

cbbayburt
cbbayburt previously approved these changes Aug 28, 2024
@admd
Copy link
Contributor

admd commented Sep 12, 2024

Thank you. @rjpmestre , it looks good to me. We need to back port this to 5.0 as well.

admd
admd previously approved these changes Sep 12, 2024
@rjpmestre rjpmestre closed this Oct 29, 2024
@rjpmestre rjpmestre reopened this Oct 29, 2024
# Conflicts:
#	java/code/src/com/redhat/rhn/domain/notification/types/UpdateAvailable.java
#	java/code/src/com/redhat/rhn/domain/notification/types/test/UpdateAvailableTest.java
� Conflicts:
�	java/code/src/com/redhat/rhn/domain/notification/types/test/UpdateAvailableTest.java
@rjpmestre rjpmestre dismissed stale reviews from admd and cbbayburt via 2163d6b October 29, 2024 17:25
@rjpmestre rjpmestre force-pushed the um_new-maintanance-update-notification branch from fdba46c to 2163d6b Compare October 29, 2024 17:25
@rjpmestre rjpmestre force-pushed the um_new-maintanance-update-notification branch from 2163d6b to 8f9c028 Compare October 29, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants