-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix version update checker #9201
base: master
Are you sure you want to change the base?
fix version update checker #9201
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request |
171ee05
to
13a5df0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾
java/spacewalk-java.changes.rjpmestre.new_maintanance_update_notification
Outdated
Show resolved
Hide resolved
Thank you. @rjpmestre , it looks good to me. We need to back port this to 5.0 as well. |
# Conflicts: # java/code/src/com/redhat/rhn/domain/notification/types/UpdateAvailable.java # java/code/src/com/redhat/rhn/domain/notification/types/test/UpdateAvailableTest.java
� Conflicts: � java/code/src/com/redhat/rhn/domain/notification/types/test/UpdateAvailableTest.java
fdba46c
to
2163d6b
Compare
…otification Co-authored-by: Ondřej Holeček <[email protected]>
2163d6b
to
8f9c028
Compare
What does this PR change?
In previous versions we had a feature to show a notification when there is a new maintenance update existed.
This relied on zypper's built-in package update checks. However, this is no longer viable for containerized versions.
It was decided the best alternative was to parse the online release notes. To streamline the parsing process across both uyuni and suma, we'd opted to include a specific HTML element—a with the id "current_version"—embedded within the release notes.
This element will contain the current stable version, formatted as follows:
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
Unit tests were added
DONE
Links
Issue(s): # https://github.com/SUSE/spacewalk/issues/24552
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!