Skip to content

Commit

Permalink
Added buton class to a tag, clean up btn css, added unstyled button c…
Browse files Browse the repository at this point in the history
…lass
  • Loading branch information
bisht-richa committed Nov 18, 2024
1 parent d3e8dcc commit d696f63
Show file tree
Hide file tree
Showing 11 changed files with 184 additions and 135 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6489,7 +6489,7 @@ organization. You may grant or remove the organization administrator role in the
</context-group>
</trans-unit>
<trans-unit id="systemgroup.details.editproperties">
<source>Edit These Properties</source>
<source>Edit System Group Properties</source>
<context-group name="ctx">
<context context-type="sourcefile">/rhn/systems/details/groups/* pages</context>
</context-group>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.spacewalk-toolbar-h1
.spacewalk-toolbar
a(href="/rhn/groups/Delete.do?sgid=#{groupId}")
a(href="/rhn/groups/Delete.do?sgid=#{groupId}" class="btn btn-danger")
i.fa.fa-trash-o(title='Delete Group')
| #{l.t("Delete Group")}
a(href="/rhn/systems/WorkWithGroup.do?sgid=#{groupId}")
a(href="/rhn/systems/WorkWithGroup.do?sgid=#{groupId}" class="btn btn-default")
i.fa.spacewalk-icon-system-groups(title='Work With Group')
| #{l.t("Work With Group")}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.spacewalk-toolbar-h1
.spacewalk-toolbar
a(href="/rhn/groups/Delete.do?sgid=#{groupId}")
a(href="/rhn/groups/Delete.do?sgid=#{groupId}" class="btn btn-danger")
i.fa.fa-trash-o(title='Delete Group')
| #{l.t("Delete Group")}
a(href="/rhn/systems/WorkWithGroup.do?sgid=#{groupId}")
a(href="/rhn/systems/WorkWithGroup.do?sgid=#{groupId}" class="btn btn-default")
i.fa.spacewalk-icon-system-groups(title='Work With Group')
| #{l.t("Work With Group")}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.spacewalk-toolbar-h1
.spacewalk-toolbar
a(href="/rhn/groups/Delete.do?sgid=#{groupId}")
a(href="/rhn/groups/Delete.do?sgid=#{groupId}" class="btn btn-danger")
i.fa.fa-trash-o(title='Delete Group')
| #{l.t("Delete Group")}
a(href="/rhn/systems/WorkWithGroup.do?sgid=#{groupId}")
a(href="/rhn/systems/WorkWithGroup.do?sgid=#{groupId}" class="btn btn-default")
i.fa.spacewalk-icon-system-groups(title='Work With Group')
| #{l.t("Work With Group")}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.spacewalk-toolbar-h1
.spacewalk-toolbar
a(href="/rhn/groups/Delete.do?sgid=#{groupId}")
a(href="/rhn/groups/Delete.do?sgid=#{groupId}" class="btn btn-danger")
i.fa.fa-trash-o(title='Delete Group')
| #{l.t("Delete Group")}
a(href="/rhn/systems/WorkWithGroup.do?sgid=#{groupId}")
| #{l.t("Delete")}
a(href="/rhn/systems/WorkWithGroup.do?sgid=#{groupId}" class="btn btn-default")
i.fa.spacewalk-icon-system-groups(title='Work With Group')
| #{l.t("Work With Group")}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.spacewalk-toolbar-h1
.spacewalk-toolbar
a(href="/rhn/groups/Delete.do?sgid=#{groupId}")
a(href="/rhn/groups/Delete.do?sgid=#{groupId}" class="btn btn-danger")
i.fa.fa-trash-o(title='Delete Group')
| #{l.t("Delete Group")}
a(href="/rhn/systems/WorkWithGroup.do?sgid=#{groupId}")
| #{l.t("Delete")}
a(href="/rhn/systems/WorkWithGroup.do?sgid=#{groupId}" class="btn btn-default")
i.fa.spacewalk-icon-system-groups(title='Work With Group')
| #{l.t("Work With Group")}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
.spacewalk-toolbar-h1
.spacewalk-toolbar
a(href="/rhn/systems/details/DeleteConfirm.do?sid=#{server.id}")
a(href="/rhn/systems/details/DeleteConfirm.do?sid=#{server.id}" class="btn btn-danger")
i.fa.fa-trash-o(title='Delete System')
| #{l.t("Delete System")}
if inSSM
a(href="/rhn/systems/details/RemoveFromSSM.do?sid=#{server.id}" class="btn btn-default")
i.fa.fa-minus-circle(title='Remove from SSM')
| #{l.t("Remove from SSM")}
else
a(href="/rhn/systems/details/AddToSSM.do?sid=#{server.id}" class="btn btn-default")
i.fa.fa-plus-circle(title='Add to SSM')
| #{l.t("Add to SSM")}
h1
if server.bootstrap
i.fa.spacewalk-icon-bare-metal
Expand Down
280 changes: 161 additions & 119 deletions java/code/webapp/WEB-INF/pages/groups/detail.jsp
Original file line number Diff line number Diff line change
@@ -1,127 +1,169 @@
<%@ taglib uri="http://rhn.redhat.com/rhn" prefix="rhn" %>
<%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c" %>
<%@ taglib uri="http://struts.apache.org/tags-html" prefix="html" %>
<%@ taglib uri="http://struts.apache.org/tags-bean" prefix="bean" %>
<%@ taglib uri="http://rhn.redhat.com/tags/list" prefix="rl" %>
<html>
<head>
</head>
<body>
<%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c" %>
<%@ taglib uri="http://struts.apache.org/tags-html" prefix="html" %>
<%@ taglib uri="http://struts.apache.org/tags-bean" prefix="bean" %>
<%@ taglib uri="http://rhn.redhat.com/tags/list" prefix="rl" %>
<html>

<%@ include file="/WEB-INF/pages/common/fragments/groups/header.jspf" %>
<head>
</head>

<div class="row-0">
<div class="col-md-6">
<div class="panel panel-default">
<body>

<div class="panel-heading">
<h3><bean:message key="systemgroup.details.status"/></h3>
</div>
<%@ include file="/WEB-INF/pages/common/fragments/groups/header.jspf" %>

<div class="panel-body">
<table class="table">
<tr>
<th><bean:message key="systemgroup.details.updates"/></th>
<td>
<div class="system-status">
<c:choose>
<c:when test="${errata_counts['se'] > 0}">
<rhn:icon type="system-crit" />
</c:when>
<c:when test="${(errata_counts['se'] == 0) && (errata_counts['be'] > 0 || errata_counts['ee'] > 0 || errata_counts['op'] > 0)}">
<rhn:icon type="system-warn" />
</c:when>
<c:otherwise>
<rhn:icon type="system-ok" />
</c:otherwise>
</c:choose>
<c:choose>
<c:when test="${errata_counts['se'] == 0 && errata_counts['be'] == 0 && errata_counts['ee'] == 0 && errata_counts['op'] == 0}">
<bean:message key="systemgroup.details.noupdates"/>
</c:when>
<c:otherwise>
<bean:message key="systemgroup.details.someupdates"/>&nbsp;&nbsp;&nbsp;
<c:if test="${errata_counts['se'] > 0}">
<bean:message key="systemgroup.details.updates.critical" arg0="/rhn/groups/ListErrata.do?sgid=${id}" arg1="${errata_counts['se']}"/>&nbsp;&nbsp;&nbsp;
</c:if>
<c:if test="${errata_counts['be'] > 0 || errata_counts['ee'] > 0 || errata_counts['op'] > 0}">
<bean:message key="systemgroup.details.updates.noncritical" arg0="/rhn/groups/ListErrata.do?sgid=${id}" arg1="${errata_counts['be'] + errata_counts['ee'] + errata_counts['op']}"/>
</c:if>
</c:otherwise>
</c:choose>
</div>
</td>
</tr>
<tr>
<th><bean:message key="systemgroup.details.admins"/></th>
<td>
<c:if test="${admin_count > 0}">
${admin_count} <bean:message key="systemgroup.details.admincount"/>
</c:if>
<c:if test="${admin_count == 0}">
<span class="no-details"><bean:message key="systemgroup.details.none"/></span>
</c:if>
<rhn:require acl="user_role(system_group_admin)">
<br />
<a href="/rhn/groups/AdminList.do?sgid=${id}" class="js-spa"><bean:message key="systemgroup.details.manageadmins"/></a>
</rhn:require>
</td>
</tr>
<tr>
<th><bean:message key="systemgroup.details.systems"/></th>
<td>
<c:if test="${system_count > 0}">
<a href="/rhn/groups/ListRemoveSystems.do?sgid=${id}" class="js-spa">
<bean:message key="systemgroup.details.systems.systems" arg0="${system_count}"/>
</a>
</c:if>
<c:if test="${system_count == 0}">
<span class="no-details"><bean:message key="systemgroup.details.none"/></span>
</c:if>
</td>
</tr>
<rhn:require acl="user_role(system_group_admin)">
<tr>
<th><bean:message key="systemgroup.details.states"/></th>
<td>
<c:if test="${minion_count > 0}">
<bean:message key="systemgroup.details.states.apply" arg0="${minion_count}" arg1="/rhn/manager/groups/details/highstate?sgid=${id}"/>
</c:if>
<c:if test="${minion_count == 0}">
<bean:message key="systemgroup.details.none"/>
</c:if>
</td>
</tr>
</rhn:require>
</table>
</div>
</div>
</div>
<div class="row-0">
<div class="col-md-6">
<div class="panel panel-default">

<div class="col-md-6">
<div class="panel panel-default">
<div class="panel-heading">
<h3><bean:message key="systemgroup.details.properties"/>
<rhn:require acl="user_role(system_group_admin)">
(<a href="/rhn/groups/EditGroup.do?sgid=${id}" class="js-spa"><bean:message key="systemgroup.details.editproperties"/></a>)
</rhn:require></h3>
</div>
<div class="panel-heading">
<h3>
<bean:message key="systemgroup.details.status" />
</h3>
</div>

<div class="panel-body">
<table class="table">
<tr>
<th><bean:message key="systemgroup.details.name"/></th>
<td><c:out value="${name}" /></td>
</tr>
<tr>
<th valign="top"><bean:message key="systemgroup.details.description"/></th>
<td><c:out value="${description}" /></td>
</tr>
</table>
</div>
</div>
</div>
</div>
<div class="panel-body">
<table class="table">
<tr>
<th>
<bean:message key="systemgroup.details.updates" />
</th>
<td>
<div class="system-status">
<c:choose>
<c:when test="${errata_counts['se'] > 0}">
<rhn:icon type="system-crit" />
</c:when>
<c:when
test="${(errata_counts['se'] == 0) && (errata_counts['be'] > 0 || errata_counts['ee'] > 0 || errata_counts['op'] > 0)}">
<rhn:icon type="system-warn" />
</c:when>
<c:otherwise>
<rhn:icon type="system-ok" />
</c:otherwise>
</c:choose>
<c:choose>
<c:when
test="${errata_counts['se'] == 0 && errata_counts['be'] == 0 && errata_counts['ee'] == 0 && errata_counts['op'] == 0}">
<bean:message key="systemgroup.details.noupdates" />
</c:when>
<c:otherwise>
<bean:message key="systemgroup.details.someupdates" />&nbsp;&nbsp;&nbsp;
<c:if test="${errata_counts['se'] > 0}">
<bean:message key="systemgroup.details.updates.critical"
arg0="/rhn/groups/ListErrata.do?sgid=${id}" arg1="${errata_counts['se']}" />
&nbsp;&nbsp;&nbsp;
</c:if>
<c:if
test="${errata_counts['be'] > 0 || errata_counts['ee'] > 0 || errata_counts['op'] > 0}">
<bean:message key="systemgroup.details.updates.noncritical"
arg0="/rhn/groups/ListErrata.do?sgid=${id}"
arg1="${errata_counts['be'] + errata_counts['ee'] + errata_counts['op']}" />
</c:if>
</c:otherwise>
</c:choose>
</div>
</td>
</tr>
<tr>
<th>
<bean:message key="systemgroup.details.admins" />
</th>
<td>
<c:if test="${admin_count > 0}">
${admin_count}
<bean:message key="systemgroup.details.admincount" />
</c:if>
<c:if test="${admin_count == 0}">
<span class="no-details">
<bean:message key="systemgroup.details.none" />
</span>
</c:if>
<rhn:require acl="user_role(system_group_admin)">
<br />
<a href="/rhn/groups/AdminList.do?sgid=${id}" class="js-spa">
<bean:message key="systemgroup.details.manageadmins" />
</a>
</rhn:require>
</td>
</tr>
<tr>
<th>
<bean:message key="systemgroup.details.systems" />
</th>
<td>
<c:if test="${system_count > 0}">
<a href="/rhn/groups/ListRemoveSystems.do?sgid=${id}" class="js-spa">
<bean:message key="systemgroup.details.systems.systems" arg0="${system_count}" />
</a>
</c:if>
<c:if test="${system_count == 0}">
<span class="no-details">
<bean:message key="systemgroup.details.none" />
</span>
</c:if>
</td>
</tr>
<rhn:require acl="user_role(system_group_admin)">
<tr>
<th>
<bean:message key="systemgroup.details.states" />
</th>
<td>
<c:if test="${minion_count > 0}">
<bean:message key="systemgroup.details.states.apply" arg0="${minion_count}"
arg1="/rhn/manager/groups/details/highstate?sgid=${id}" />
</c:if>
<c:if test="${minion_count == 0}">
<bean:message key="systemgroup.details.none" />
</c:if>
</td>
</tr>
</rhn:require>
</table>
</div>
</div>
</div>

</body>
</html>
<div class="col-md-6">
<div class="panel panel-default">
<div class="panel-heading">
<h3>
<bean:message key="systemgroup.details.properties" />
<rhn:require acl="user_role(system_group_admin)">
<a href="/rhn/groups/EditGroup.do?sgid=${id}"
title="<bean:message key='systemgroup.details.editproperties' />" role="button"
class="js-spa btn-unstyled pull-right">
<rhn:icon type="item-edit" />
</a>
</rhn:require>
</h3>
</div>

<div class="panel-body">
<table class="table">
<tr>
<th>
<bean:message key="systemgroup.details.name" />
</th>
<td>
<c:out value="${name}" />
</td>
</tr>
<tr>
<th valign="top">
<bean:message key="systemgroup.details.description" />
</th>
<td>
<c:out value="${description}" />
</td>
</tr>
</table>
</div>
</div>
</div>
</div>

</body>

</html>
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@

.panel-heading,
th {
.btn,
.btn-link,
a:not(.btn-unstyled) {
border: none;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const renderFilterEntry = (filter, projectId, symbol, last) => {
icon="fa-edit"
title={t("Edit Filter {name}", { name: filter.name })}
className="pull-right js-spa"
unstyled
href={`/rhn/manager/contentmanagement/filters?openFilterId=${filter.id}&projectLabel=${projectId}`}
/>
</div>
Expand Down
Loading

0 comments on commit d696f63

Please sign in to comment.