Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ssl libertylinux 9 workaround. #1738

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Remove ssl libertylinux 9 workaround. #1738

merged 1 commit into from
Oct 17, 2024

Conversation

maximenoel8
Copy link
Contributor

What does this PR change?

Remove ssl libertylinux 9 workaround.

@maximenoel8 maximenoel8 self-assigned this Oct 16, 2024
@maximenoel8 maximenoel8 requested a review from a team October 16, 2024 02:32
ktsamis
ktsamis approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the context why we don't need this anymore but the PR looks fine

srbarrios
srbarrios approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just please link the card that have the details about the previous issue, to have some context when people review this.

@maximenoel8
Copy link
Contributor Author

If you look in the 'events', you can see I linked the issue.
image

@srbarrios
Copy link
Member

If you look in the 'events', you can see I linked the issue.

Thank you, sorry that was not visible from the GitHub Mobile App :)

@srbarrios
Copy link
Member

I think is unrelated.. but we have this issue:
image

@maximenoel8
Copy link
Contributor Author

maximenoel8 commented Oct 16, 2024 •
edited
Loading

Yes I was having a look at it. I don't really understand those github actions..

@maximenoel8 maximenoel8 merged commit 5c59e92 into uyuni-project:master Oct 17, 2024
2 checks passed
@maximenoel8 maximenoel8 deleted the remove_liberty9_repo_workaround branch October 17, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bischoff Bischoff Bischoff approved these changes

@srbarrios srbarrios srbarrios approved these changes

@ktsamis ktsamis ktsamis approved these changes

@NamelessOne91 NamelessOne91 NamelessOne91 approved these changes

Assignees

@maximenoel8 maximenoel8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maximenoel8 @srbarrios @Bischoff @ktsamis @NamelessOne91