-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade libvirt provider to v0.8.0 #1723
base: master
Are you sure you want to change the base?
Upgrade libvirt provider to v0.8.0 #1723
Conversation
Can you have a look at the description of this PR [1] since it can give you some tips about what needs to be checked and changed in our CI. |
Thanks for the heads up, Ricardo. Currently this PR is just a placeholder for future work. ATM, I was able to build it an OBS branch under my namespace https://build.opensuse.org/package/show/home:pinvernizzi:branches:systemsmanagement:sumaform/terraform-provider-libvirt and I'm trying it out locally (I'm on Tumbleweed). |
In my opinion we should stop building it ourselves and just use the upstream libvirt terrform provider. It would simplify our life, and we can path it if needed. |
If you can find a spare moment to do so, let's discuss this with @Bischoff next week. |
I the last 5 years I have never seen the need to release a patch for libvirt ourselves. But if needed we can make it using the infra from hashicorp providers [1] [2]. If we want we can discuss it during next week. Cheers [1] https://registry.terraform.io/providers/uyuni-project/libvirt/latest |
What does this PR change?
Related to https://github.com/SUSE/spacewalk/issues/25018
Update the libvirt provider to v0.8.0 - the last available version at the time of writing.
Unfortunately, the new version changes cpu definition for libvirt_domain resources from an attribute to a block and breaks backward compatibility with our libvirt module.
Pre-requisites
When this PR is merged, we need to:
terraform-provider-libvirt
/terraform
together with that in the OBS if necessary/wantedHow to upgrade
zypper rm terraform-provider-libvirt
0.8.0
keeping state file
. Otherwise just clan the environment and remove theterraform.tfstate
,.terraform.lock.hcl
and.terraform
terraform init
Keeping state file
terraform.tfstate
cpu
keys. The value should now be an array of objects. To change it just surround the existing content with square brackets ([ {....} ]
)terraform init -upgrade