Set auto_connect_to_master to False for sshminion #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nect to master. This value should be false by default.
Bischoff
approved these changes
Oct 3, 2024
srbarrios
approved these changes
Oct 3, 2024
NamelessOne91
approved these changes
Oct 3, 2024
maximenoel8
deleted the
auto_connect_master_sshminion_default_value_false
branch
rjmateus
reviewed
Oct 3, 2024
| @@ -15,7 +15,7 @@ variable "product_version" { | |||
|
|
|||
| variable "auto_connect_to_master" { | |||
| description = "whether this minion should automatically connect to the Salt Master upon deployment" | |||
| default = true | |||
| default = false | |||
There was a problem hiding this comment.
Why change the default? our CI can set the variable to everything it's wanted in there. Changing the default means each developer that want to setup a fast environment will need to set the flag or manually onboard. That is going in a different direction of what was in place for Sumaform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
In our BV testing, for the sshminion, we don't set
auto_connect_to_mastervariable to false so all the sshminion are set to auto connect to master.BUT when we do our test, the sshminion are not visible. Indeed the
server_configuration['hostname']is not settable ( no declare in variables.tf ) for sshminion so the minion run without proper configuration and with that we delete venv-salt-minion before bootstrapping.Because server_configuration is not an available variable for sshminion, we can't configure the auto connect to master.
Set the default variable
auto_connect_to_masterto false for now. We may need to either addserver_configurationto sshminion or removeauto_connect_to_master.