date: fix subfmt-up1, fill-1, pct-pct, and invalid-high-bit-set tests / implement --debug by sylvestre · Pull Request #10940 · uutils/coreutils

sylvestre · 2026-02-14T21:10:02Z

based on #10939

should fix tests/date/date.pl

github-actions · 2026-02-14T21:28:54Z

GNU testsuite comparison:

GNU test failed: tests/factor/t29. tests/factor/t29 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/date/date is no longer failing!
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Congrats! The gnu test tests/pr/bounded-memory is now passing!

ChrisDryden · 2026-02-14T21:40:27Z

src/uu/date/src/format_modifiers.rs

+//! Format: `%[flags][width]specifier`
+//!
+//! ### Flags
+//! - `-`: Left-align (pad with spaces on the right)


I think this flag is incorrect, when I'm testing with different - modifiers It appears to be suppressing all padding

ChrisDryden · 2026-02-14T21:48:20Z

src/uu/date/src/format_modifiers.rs

+        return result;
+    }
+
+    let pad_char = if flags.contains('0') {


This might be better for a follow up but I think the logic here is a bit more complicated since the pad char can be dependent on the specifier. When I'm running different modifiers locally I am sometimes seeing that the ordering of the modifiers themselves like doing _+

codspeed-hq · 2026-02-14T21:48:23Z

Merging this PR will degrade performance by 39.09%

❌ 6 regressed benchmarks
✅ 282 untouched benchmarks
⏩ 38 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Simulation	`file_custom_format`	11.7 ms	16 ms	-26.75%
❌	Simulation	`complex_relative_date`	247 µs	258.9 µs	-4.58%
❌	Simulation	`single_date_now`	194.7 µs	207.2 µs	-6.04%
❌	Simulation	`file_tz_abbreviations`	16 ms	24.3 ms	-34.04%
❌	Simulation	`file_iso_dates`	12.3 ms	20.1 ms	-39.09%
❌	Memory	`file_tz_abbreviations`	333.4 KB	529.2 KB	-37%

_{Comparing sylvestre:date-pl-5 (200afd1) with main (e7f2fd9)}

38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-02-14T21:49:40Z

GNU testsuite comparison:

GNU test failed: tests/factor/t29. tests/factor/t29 is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/date/date is no longer failing!

src/uu/date/src/format_modifiers.rs

ChrisDryden · 2026-02-14T21:57:02Z

Bravo 🥳 When you said you had a working fix for date.pl I didn't think you also had the start of the debug flag work done too.

github-actions · 2026-02-14T22:35:08Z

GNU testsuite comparison:

Congrats! The gnu test tests/factor/t34 is no longer failing!
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Congrats! The gnu test tests/tail/retry is no longer failing!
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/cut/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/tail-n0f is now passing!

src/uu/date/src/format_modifiers.rs

ChrisDryden · 2026-02-14T22:46:07Z

I'm thinking just for the sake of it being a big PR and that its net new functionality it would be better to merge then address the fixes as follow ups, once the gnu test is passing?

sylvestre · 2026-02-15T09:27:26Z

indeed and i have a differential fuzzer ready to run :)

github-actions · 2026-02-15T09:58:48Z

GNU testsuite comparison:

GNU test failed: tests/factor/t10. tests/factor/t10 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/factor/t33. tests/factor/t33 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/factor/t34. tests/factor/t34 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/date/date is no longer failing!
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

sylvestre force-pushed the date-pl-5 branch from df3c954 to 16b3ec0 Compare February 14, 2026 21:35