Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksumming, refactor code #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

OmSaran
Copy link
Contributor

@OmSaran OmSaran commented Dec 14, 2021

This adds some fixes but I'm not super confident of the changes due to 2 reasons:

  1. I've not tested it thoroughly, I've only tested it via some additional non-related changes to this file
  2. Some design decisions I made: using posix system calls instead of splitfs calls in order to avoid logging it again. But I think we need to ensure persistence in this case which I have not done currently in the PR

@OmSaran OmSaran mentioned this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant