Delete the contents of the save directory before export #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… up cruft (old assets, etc.) (cherry picked from commit 7a9c717)
fortinmike
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting a spec repeatedly while tweaking assets for integration, the assets directory of the spec can become full of unwanted, old assets.
This pull request adds a cleanup step before each export where the save path is deleted recursively to keep the spec clean and representative of the actual assets in the latest version of the Sketch document.
This seems like a desirable default behaviour. I didn't notice a performance difference with or without the cleanup.
Please consider merging this into mainline!