-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a first draft of a generic IK functionality #4
Open
JonathanKuelz
wants to merge
15
commits into
utiasSTARS:revisions
Choose a base branch
from
JonathanKuelz:dev/generic_ik_interface
base: revisions
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adds a first draft of a generic IK functionality #4
JonathanKuelz
wants to merge
15
commits into
utiasSTARS:revisions
from
JonathanKuelz:dev/generic_ik_interface
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned model on goals and robot kinematics solely defined via torch Tensors
Closes #3 |
I implemented everything I planned to. I added some tests that indicate everything is working properly. However, I am not too happy with the current runtime: on my Desktop PC, I average ~600ms per robot for an IK with 32 samples. I tried speeding it up by batching the requests for multiple IK, but it did not really help much. I see the following problems:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to introduce an "api" (or interface) that allows using a pretrained model for downstream tasks without all the effort of transforming problems / data manually.
Eventually, the goal is to provide an
ik
function that takes:and returns either the best available of S sampled ik solutions or all S samples.
This PR provides the code for this ik function, but also utilities to load a pretrained model easily and also help with data transformations torch <-> generative_graphik without being too familiar with the orginal code.