[WIP] Proposed changes for V1 restapi helpers #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move validation for expected content to helpers file
keithmanville
requested changes
May 22, 2024
There was a problem hiding this comment.
Does the try/except ValueError with message pattern provide the most informative message in pytest? i.e. is it adding something over just having the sequence of asserts?
I tested this on my in progress queues branch and it works (after making the suggested changes with group_ref.
I like breaking the repeated chunks into helpers.
I suggest we get users/groups merged into dev, thenre base this and integrate the new pattern into test_user and test_group before merging this PR.
| assert isinstance(group_ref["group"]["name"], str) | ||
| assert isinstance(group_ref["group"]["url"], str) | ||
| assert group_ref["id"] == expected_contents["group"]["id"] | ||
| return True |
There was a problem hiding this comment.
group_ref doesn't have a "group" key. Should just be group_ref["name"] etc.
| assert isinstance(response["latestSnapshot"], bool) | ||
| except ValueError("Response keys do not match expected keys types"): | ||
| return False | ||
|
|
There was a problem hiding this comment.
black caught some extra whitespace characters here and a couple other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move validation for expected content to helpers file