Add span events #833
Open
Add span events #833
+294
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdr400
requested changes
Jan 20, 2025
fdr400
reviewed
Jan 20, 2025
segoon
reviewed
Jan 20, 2025
otlp/src/otlp/logs/logger.cpp
Outdated
| @@ -176,12 +273,17 @@ void Logger::Trace(logging::Level level, std::string_view msg) { | |||
| if (key == "timestamp" || key == "text") { | |||
| return true; | |||
| } | |||
| if (key == "events") { | |||
There was a problem hiding this comment.
это место скоро поменяется, у меня уже есть патч на добавление JSON логов
подожди, пока он приземлится, и тогда нужно будет поменять это место
nepridumalnik
force-pushed
the
add_span_events
branch
from
d55a8ba to
72be837
Compare
nepridumalnik
force-pushed
the
add_span_events
branch
from
72be837 to
dcbf250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add span events to opentelemetry