feat cmake: add download_userver() and cmake presets #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton3
changed the title
Anton3
changed the title
segoon
reviewed
Dec 18, 2024
.github/workflows/ci.yml
Outdated
| sudo apt update | ||
| sudo apt install --allow-downgrades -y $(cat third_party/userver/scripts/docs/en/deps/${{matrix.os}}.md | tr '\n' ' ') | ||
| sudo apt install --allow-downgrades -y $(wget -q -O - ${DEPS_FILE} | tr '\n' ' ') |
| @@ -44,9 +44,9 @@ jobs: | |||
|
|
|||
| - name: Install packages | |||
| run: | | |||
| (cd third_party && git clone -b develop --single-branch --depth 1 https://github.com/userver-framework/userver.git) | |||
| DEPS_FILE="https://raw.githubusercontent.com/userver-framework/userver/refs/heads/develop/scripts/docs/en/deps/${{matrix.os}}.md" | |||
There was a problem hiding this comment.
зачем качать самый новый список? почему не качать то, что есть в репозитории в ветке?
There was a problem hiding this comment.
Качаю то, что есть в репозитории (userver) в ветке (develop)
Зачем качать отдельно - потому что чтобы userver скачался через CPM, нужно вначале корректно прогнать cmake для сервиса, а для этого нужно вначале поставить пакеты, а для этого нужно вначале получить список пакетов
Мне не нравится способ, когда мы прогоняем cmake сервиса с ожидаемой ошибкой сборки и смотрим в build-директорию
| @@ -13,3 +13,4 @@ cmake-build-* | |||
| Testing/ | |||
| .DS_Store | |||
| Makefile.local | |||
| CmakeUserPresets.json | |||
There was a problem hiding this comment.
vscode без них не заводится, и за ними будущее, это рекомендуемый бескостыльный способ прописывать флаги сборки
- Makefile не подцепляется в IDE -> всё красное, нет intellisense
set(... FORCE)вCMakeLists.txt- костыль:- перетирает доку
- так нельзя настроить компилятор, линкер, генератор
- так нельзя настроить флаги локально без коммита
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.