Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow mobile user zooming in image preview #3880

Merged
merged 4 commits into from
Sep 22, 2024
Merged

Conversation

auphone
Copy link
Contributor

@auphone auphone commented Sep 4, 2024

Allow mobile user to zoom by temporary set the user-scalable attribute to yes in viewport meta.
Reset to no before the dialog destroy.

web/src/components/PreviewImageDialog.tsx Outdated Show resolved Hide resolved
web/src/components/PreviewImageDialog.tsx Outdated Show resolved Hide resolved
web/src/components/PreviewImageDialog.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@boojack boojack changed the title Allow mobile user zooming in image preview feat: allow mobile user zooming in image preview Sep 22, 2024
@boojack boojack merged commit 0711ac4 into usememos:main Sep 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants