Feat/ Add Multiline Support for Enviroment Variables #5438
Merged
+596
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pragadesh-45
requested review from
helloanoop,
maintainer-bruno,
bijin-bruno,
lohit-bruno and
naman-bruno
as code owners
sanish-bruno
suggested changes
Aug 28, 2025
| if (value && (value.includes('\n') || value.includes('\r'))) { | ||
| // Use multiline format with triple quotes | ||
| const indentedValue = value.split('\n').map(line => ` ${line}`).join('\n'); | ||
| return ` ${prefix}${name}: '''\n${indentedValue}\n'''`; |
There was a problem hiding this comment.
@Pragadesh-45 i guess we will need to add indentation, ''' should start indented, I guess we should also indent the multiline value as shown, rather than it being inline with abc
vars : {
abc: '''
{
key:value
}
'''
}
If we don't indent the value, it may look like
vars : {
abc: '''
key:value
key2: value
'''
}
let me know your thoughts on this, i believe i did with the indentation within grpc, we should have a conversation on this
There was a problem hiding this comment.
sure, i'll update the pr
| @@ -113,15 +116,43 @@ const sem = grammar.createSemantics().addAttribute('ast', { | |||
| }, | |||
| pair(_1, key, _2, _3, _4, value, _5) { | |||
| let res = {}; | |||
| res[key.ast] = value.ast ? value.ast.trim() : ''; | |||
| res[key.ast] = value.ast !== undefined ? value.ast : ''; | |||
There was a problem hiding this comment.
@Pragadesh44-Bruno what is the impact on removing the trim(), I think this can cause some inconsistencies or regression as this has been used for quite some time!
There was a problem hiding this comment.
i have added this to preserve the white spaces since it is important for the values to be handled properly (especially for multiline)
Pragadesh-45
force-pushed
the
feat/multiline-values-for-env-vars
branch
from
5698d4f to
a43a113
Compare
sanish-bruno
approved these changes
Aug 29, 2025
- Updated SingleLineEditor to allow newlines when `allowNewlines` prop is true, otherwise runs the handler on Shift-Enter. - Modified grammar in envToJson to support multiline text blocks with triple quotes. - Updated jsonToEnv to format values with newlines using triple quotes for better readability. - refactor: replace `SingleLineEditor` with `MultilineEditor` to support newLines
Pragadesh-45
force-pushed
the
feat/multiline-values-for-env-vars
branch
from
83a4195 to
99ed018
Compare
- Simplified multiline string processing in envToJson by removing unnecessary checks and directly slicing leading spaces. - Introduced getValueString function in jsonToEnv to handle multiline strings with proper indentation and formatting. - Added indentString4 utility function for consistent 4-space indentation across the codebase.
- Updated grammar to define start and end for multiline text blocks. - Simplified value extraction for multiline strings by directly returning the AST. - Improved indentation handling by removing leading spaces from multiline content.
- Implemented tests to read and create multiline environment variables. - Verified successful request execution and response handling for multiline JSON data. - Added necessary collection and environment files for testing.
- Deleted the `bruMultiline.spec.js` file as it is no longer needed. - This cleanup helps maintain a lean test suite and reduces redundancy.
- Updated `jsonToEnv` to use `indentString` for consistent indentation of variable names and values. - Simplified `getValueString` to trim trailing whitespace and ensure proper formatting of multiline values. - Removed unnecessary parameters for cleaner utility functions.
Pragadesh-45
force-pushed
the
feat/multiline-values-for-env-vars
branch
from
752748e to
a616d81
Compare
helloanoop
approved these changes
Sep 6, 2025
This was referenced Sep 6, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4518 #1581 #1953
Related to: #4827
Description
This PR adds support for multiline environment variables by updating the environment parsing logic in
envToJsonandjsonToEnvhas been enhanced to handle multiline values using triple quotes (''') for better readability and formatting.Comprehensive tests have been added, including integration tests for round-trip conversion between JSON and
.bruformats, as well as expanded unit tests covering edge cases like special characters, empty values, and global environment variables.Contribution Checklist:
COLLECTION ENVIRONMENTS
GLOBAL ENVIRONMENTS
