Fix scale and extent issues in Elephant #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the elephant had extents that were 110x smaller than they should have been authored the elephant and the monochord. I left the transform at the root of the object, because it does indeed seem quite small, but fixed the extents by recomputing them via UsdGeomBoundable.
meshula
approved these changes
Feb 22, 2024
jcowles
force-pushed
the
jcowles/elephant_fix
branch
from
d527499
to
56564fe
Compare
|
Fixes #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the elephant had extents that were 110x smaller than they should have been authored the elephant and the monochord. I left the transform at the root of the object, because it does indeed seem quite small, but fixed the extents by recomputing them via UsdGeomBoundable.