fix: handle dead VMM and scan all urunc TAP devices during cleanup#476
Open
goyalpalak18 wants to merge 1 commit intourunc-dev:mainfrom
Open
fix: handle dead VMM and scan all urunc TAP devices during cleanup#476goyalpalak18 wants to merge 1 commit intourunc-dev:mainfrom
goyalpalak18 wants to merge 1 commit intourunc-dev:mainfrom
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cmainas
reviewed
Feb 13, 2026
Contributor
cmainas
left a comment
There was a problem hiding this comment.
Hello @goyalpalak18 ,
the changes look good. I have only left two small comments. Do not forget to fix the linting issues and rebase over main.
Signed-off-by: goyalpalak18 <goyalpalak1806@gmail.com>
cce0f5c to
cfeaadb
Compare
Contributor
Author
|
Thanks @cmainas ! Just pushed these updates and rebased over main. Let me know if everything looks good now. |
cmainas
reviewed
Feb 18, 2026
Contributor
cmainas
left a comment
There was a problem hiding this comment.
Thank you @goyalpalak18 for the changes. One thing I noticed is that if something fails during a cleanup of a single device then the function returns ignoring the rest. So it would be better to log the error but not return immediately but later at the end of the loop. Also, please rebase over main, so we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the issue where
vmm.Stop()was returning an error if the process was already dead (like from a crash), which prevented network cleanup from running.I updated
killProcessinutils.goto treatESRCH(process not found) as a success. If it's gone, it's gone, so we can proceed.Also refactored
network.Cleanupto actually scan for anytap.*_uruncinterfaces instead of looking for a hardcoded string. This handles leftover devices much better.Huge thanks to @sidneychang for the scanning logic in #407 — I integrated that here.
Related issues
Fixes #408
Integrates #407
How was this tested?
make lintpasses.