Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): Deprecate & Remove @urql/storybook-addon #3067

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 16, 2023

Summary

Remove & Deprecate @urql/storybook-addon.
I think we can eventually make a better mockExchange as a replacement, but the plugin itself doesn't serve much of a purpose right now and has gone unmaintained.

Set of changes

  • Remove packages/storybook-addon

Copy link
Collaborator

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES

@kitten kitten merged commit 20ce654 into main Mar 16, 2023
@kitten kitten deleted the chore/deprecate-storybook-addon branch March 16, 2023 16:50
@dkolman-vendavo
Copy link

Soooo...... What is the recommended approach for developing components in Storybook? mockExchange may be nice but I like how I can compose parameters in storybook - e.g. with msw-storybook-addon I can define some request mocks globally, some for all stories in a file, and override some for just one story.

@kitten
Copy link
Member Author

kitten commented May 4, 2023

@dkolman-vendavo: I haven't written up an RFC yet, but the likely successor is a bundled @urql/testing package. It's looking likely that storybook helpers will move there, if we can find more convenient ways to ensure that they'll work for all UI bindings equally.

For now, I'm treating this as tracked by #3133 until a new RFC replaces it.

It's a bit of an unfortunate situation that we didn't foresee in time. The package wasn't previously documented or had a place for docs where we could track this.
But in short, for now you can still rely on it until an alternative becomes available.

The longer story here is that it didn't receive maintenance and the new version of Storybook came around. However, it didn't live up to our standards either because the package was only targeting React properly, so a replacement is and was needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants