Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(populate) - refactor and increase reliability of query-reading #1872

Closed
wants to merge 10 commits into from

Conversation

yankovalera
Copy link
Contributor

@yankovalera yankovalera commented Aug 18, 2021

Summary

(relates to #964) Increase feature-set of the populateExchange. Address "classic" mode. As discussed with @JoviDeCroock we might address other cases in other PRs.

"Classic" mode for populate exchange:

mutation { addTodo @populate }

We find out what type is used inside of the [[Mutation]] and look in our data-structure what fields we've used for this type.

Set of changes

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2021

🦋 Changeset detected

Latest commit: b6c5240

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-populate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yankovalera yankovalera marked this pull request as ready for review August 18, 2021 16:13
@yankovalera yankovalera self-assigned this Aug 18, 2021
@kitten kitten marked this pull request as draft August 18, 2021 16:53
@yankovalera yankovalera marked this pull request as ready for review August 19, 2021 10:30
@JoviDeCroock JoviDeCroock changed the title Refactor/populate exchange (populate) - refactor and increase reliability of query-reading Aug 19, 2021
@yankovalera yankovalera marked this pull request as draft August 20, 2021 16:27
@yankovalera yankovalera marked this pull request as ready for review September 2, 2021 10:51
@kitten
Copy link
Member

kitten commented Jan 10, 2023

Superseded by #2897. Co-Author tag should potentially be added there

@kitten kitten closed this Jan 10, 2023
@kitten kitten deleted the refactor/populate-exchange branch March 6, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants