Skip to content

Conversation

@illia-v
Copy link
Member

@illia-v illia-v commented Apr 9, 2025

  • Draft a social media announcement
  • See if all tests, including downstream, pass
  • Get the release pull request approved by a CODEOWNER
  • Squash merge the release pull request with message "Release <VERSION>"
  • Tag with X.Y.Z, push tag on urllib3/urllib3 (not on your fork, update <REMOTE> accordingly)
    • Notice that the <VERSION> shouldn't have a v prefix (Use 1.26.6 instead of v.1.26.6)
    • # Ensure the release commit is the latest in the main branch.
      export VERSION=<X.Y.Z>
      export REMOTE=origin
      git checkout main
      git pull $REMOTE main
      git tag -s -a "$VERSION" -m "Release: $VERSION"
      git push $REMOTE --tags
      
  • The tag will trigger the publish GitHub workflow. This requires a review from a maintainer.
  • Ensure that all expected artifacts are added to the new GitHub release. Should
    be one .whl and one .tar.gz. Update the GitHub
    release to have the content of the release's changelog and any ongoing announcements.
  • Announce on:
    • Social media
    • Discord
    • Open Collective
  • Check Tidelift security maintenance plan is still correct
  • If this was a 1.26.x release, add changelog to the main branch

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sethmlarson
Copy link
Member

Our macOS CI tests are suddenly failing though, I'm curious about that?

@illia-v
Copy link
Member Author

illia-v commented Apr 10, 2025

Our macOS CI tests are suddenly failing though, I'm curious about that?

Yeah, I noticed this today too

Difference between one of the last successful runs and a failing one is changed macOS from 15.3.2 24D81 to 15.4 24E248

@illia-v
Copy link
Member Author

illia-v commented Apr 10, 2025

Newer memray seems to fix the issue #3589

@illia-v illia-v merged commit a5ff7ac into urllib3:main Apr 10, 2025
29 of 35 checks passed
@illia-v illia-v deleted the release-2.4.0 branch April 10, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants