Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incompatibility that occurred after updating urfave/cli (v3.0.0-alpha9.2) #6

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

tarampampam
Copy link
Contributor

@tarampampam tarampampam commented Nov 4, 2024

After the changes in urfave/cli#1988 were released under v3.0.0-alpha9.2, this package stopped working due to the removal of the GetValue() string function from the cli.DocGenerationFlag interface.

This PR provides a workaround, which, while a bit rough, is functional and may serve as a temporary solution until a better approach is developed.

Closes #5

@tarampampam tarampampam requested a review from a team as a code owner November 4, 2024 15:51
@tarampampam
Copy link
Contributor Author

@dearchap, could you please update the "Branch protection rules" in this repo?

image

@tarampampam
Copy link
Contributor Author

Friendly ping @dearchap @urfave

@dearchap dearchap merged commit 31c0a70 into main Nov 6, 2024
6 checks passed
@Juneezee Juneezee deleted the fix-issue-5 branch November 6, 2024 12:12
@tarampampam
Copy link
Contributor Author

@dearchap Can I publish a new v3.0.0-alpha6 release? Or could you do it?

@dearchap
Copy link
Contributor

dearchap commented Nov 6, 2024

Go ahead

@Juneezee
Copy link
Member

Juneezee commented Nov 6, 2024

The new version should be v3.0.0-alpha.6. See the discussion in here urfave/cli#1985 (comment)

@tarampampam
Copy link
Contributor Author

I've released v3.0.0-alpha.6, but since v3.0.0-alpha5 (previous tag) is greater than v3.0.0-alpha.6 (current latest), Dependabot/RenovateBot/go get -u won't automatically update to this version with the fixes 😞

image

@Juneezee do you have any suggestions on how to resolve this?

@bartekpacia
Copy link
Member

@tarampampam just release v3.0.0-alpha6 instead? this is the versioning schema urfave/cli uses:

Screenshot 2024-11-06 at 21 25 40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code generation appears to be broken
4 participants