Refactor WebViewForwardHandler typealias usage#448
Merged
rlepinski merged 1 commit intourbanairship:mainfrom Feb 17, 2026
Merged
Refactor WebViewForwardHandler typealias usage#448rlepinski merged 1 commit intourbanairship:mainfrom
rlepinski merged 1 commit intourbanairship:mainfrom
Conversation
Refactor forward navigation delegate type to use typealias for clarity.
Contributor
Author
|
If this is an acceptable modification, would it be possible to generate a fix for the 19.x version of the library as well? Due to project requirements, we currently cannot update the minimum target and therefore must use the 19.x version. |
Contributor
|
This looks great and yes we can back port it. Thank you for the PR! |
Contributor
|
Ignore the Gemini PR review failure. |
Contributor
|
@kajinka13 https://github.com/urbanairship/ios-library/tree/19.x if you are using SPM, ill do actual releases tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor forward navigation delegate type to use typealias for clarity.
What do these changes do?
I fixed a casting that causes compilation to fail on Xcode 26.4b1 (no code changes)
Why are these changes necessary?
Using the new xcode to test iOS 24, the application fails to compile
How did you verify these changes?
as I was saying, the change is a simple refactoring of the casting, it does not involve changes to the application structure, but allows its compilation with the new toolchain
Verification Screenshots:
Anything else a reviewer should know?
no