DX-1547: sync/async serve with duplication #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CahidArda
reviewed
Jan 13, 2025
Comment on lines
+1
to
+6
| from inspect import iscoroutinefunction | ||
| from fastapi import FastAPI, Request, Response | ||
| from typing import Callable, Awaitable, cast, TypeVar | ||
| from typing import Callable, Awaitable, cast, TypeVar, Union | ||
| from upstash_workflow.serve.serve import serve | ||
| from upstash_workflow.context.context import WorkflowContext | ||
| from upstash_workflow.asyncio.serve.serve import serve as async_serve |
There was a problem hiding this comment.
we should probably do this in another PR to avoid breaking the existing PRs but the fastapi integration shouldn't be here I think. Do you think it makes sense to add a folder for the integrations?
CahidArda
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.