Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-1573: raise error on parallel execution with asyncio.gather() #24

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

yunusemreozdemir
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Jan 20, 2025

DX-1573 workflow-py detect and handle parallel steps

sancar said:

We had one concern about the current state.

Currently, parallel steps are not supported(postponed because it will take some more time to implement it).
But, that we can’t stop our users to try to do parallel runs. They can always skip waiting the promises returned by steps.

emre.ozdemir What is the behaviour right now? Can we detect that there is use of parallel steps. and fail the workflow(with printing warning on their environmets) ?
If yes, that could be enough to release as is.
Otherwise, if the workflow will hang or act unexpectedly, it feels unsafe to release.

@CahidArda CahidArda merged commit 560656e into master Jan 21, 2025
1 check passed
@mdumandag mdumandag deleted the DX-1573 branch January 21, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants