Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for ERC 1271 #33

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Muhammad-Altabba
Copy link

This pull is to add support for ERC 1271 and it includes:

  • Upgrading truffle to version 5.1.43 which includes:
    • Upgrading solidity code to v0.5.16 and handle its breaking changes
    • Updating test cases code for the breaking changes of Web3 v1.2.1
  • Adding checkSignature' and other methods overloading to EthereumDIDRegistryto make it compatible withERC1271`
  • Adding test cases Signed methods …
  • Writing tests for using Contract Signature at EthereumDIDRegistry
    • Also, test the Smart Contract overlading methods that accept the composed signature that is signed by a private key
    • And, add a simple ERC1271 Sample contract and use it in the test cases.

maltabba added 6 commits September 8, 2020 11:40
 - Upgrade solidity code to v0.5.16 and its breaking changes
  - Update test cases code for the breaking changes of web3 v1.2.1
 - Test the methods that accepts the composed signature that is signed by a private key
Copy link

@andresobandoalfaro andresobandoalfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Contribution I downloaded the code and test it deploying the contracts in a private network, and it worked pretty smoothly, the tests provided in test/ethereum_did_registry.js has also great value.

@ottomorac
Copy link

hello @mirceanis , as @andresobandoalfaro pointed out this code worked really well for us. You way want to consider merging it in. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants