Skip to content

Conversation

@nd0ut
Copy link
Member

@nd0ut nd0ut commented May 22, 2025

Description

Checklist

@github-actions
Copy link

L10N stats:

@nd0ut nd0ut force-pushed the feat/add-ngdrive-translations branch from 1b9bdf1 to f1da51e Compare May 22, 2025 10:34
@nd0ut nd0ut requested review from Copilot and egordidenko May 22, 2025 10:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a separate ngdrive translation block alongside existing gdrive entries to support Next-Gen Drive menus and search in multiple locales.

  • Introduces ngdrive key under sourceName and lineA with the same copy as gdrive
  • Adds a new top-level ngdrive section in each locale containing menu, search, and openPicker entries
  • Updates 21 locale files to include the new translations

Reviewed Changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ko.js Added ngdrive under sourceName, lineA, and new ngdrive section
kk.js Same as above for Kazakh locale
ka.js Same as above for Georgian locale
ja.js Same as above for Japanese locale
it.js Same as above for Italian locale
is.js Same as above for Icelandic locale
hy.js Same as above for Armenian locale
he.js Same as above for Hebrew locale
fr.js Same as above for French locale
et.js Same as above for Estonian locale
es.js Same as above for Spanish locale
en.js Same as above for English locale
el.js Same as above for Greek locale
ee.js Same as above for Ewe locale
de.js Same as above for German locale
da.js Same as above for Danish locale
cs.js Same as above for Czech locale
ca.js Same as above for Catalan locale
az.js Same as above for Azerbaijani locale
ar.js Same as above for Arabic locale
Comments suppressed due to low confidence (1)

en.js:102

  • There are no tests verifying that the new ngdrive keys exist and are correctly structured in each locale. Adding a locale completeness test would help catch missing or malformed translations in future updates.
ngdrive: {

button: "Search",
},
},
ngdrive: {
Copy link

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ngdrive translation block is duplicated verbatim across all locale files, which may become hard to maintain as we add more locales or update labels. Consider extracting this block into a shared template or automating its insertion to reduce repetition.

Copilot uses AI. Check for mistakes.
@nd0ut nd0ut merged commit 3bd10b3 into master May 23, 2025
1 check passed
@nd0ut nd0ut deleted the feat/add-ngdrive-translations branch May 23, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants