-
Notifications
You must be signed in to change notification settings - Fork 3
Update Observability guides #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
markandersontrocme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| about the features Upbound offers for collecting telemetry from control planes. | ||
|
|
||
|
|
||
| ## Router metrics reference {#router-ref} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be worth noting somewhere that you can also just scrape these metrics via prometheus
port: 9901 and path: /stats/prometheus.
| about the features Upbound offers for collecting telemetry from control planes. | ||
|
|
||
|
|
||
| ## Router metrics reference {#router-ref} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can likely uncomment these now:
| <!-- Track these critical Envoy metrics for the spaces-router: --> |
or maybe add some of those details here and link to them? I do like the focused set of metrics we call out on that page, with the bit of adding context.
users can get to those via space-level telemetry now in 1.15 (and by scraping them directly even in previous spaces versions)
Description
Type of change
Checklist
make lintlocally (or will fix Vale suggestions in review)Additional notes