Skip to content

Conversation

@tr0njavolta
Copy link
Member

Description

Type of change

  • Bug fix (typo, broken link, incorrect info)
  • Content update (new info, clarification, reorganization)
  • New content (new page, section, or guide)

Checklist

  • I ran make lint locally (or will fix Vale suggestions in review)
  • Links work and point to the right places
  • If this adds new content, I tested the examples/instructions

Additional notes

@vercel
Copy link

vercel bot commented Oct 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Oct 29, 2025 10:50pm

Copy link
Member

@markandersontrocme markandersontrocme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

about the features Upbound offers for collecting telemetry from control planes.


## Router metrics reference {#router-ref}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be worth noting somewhere that you can also just scrape these metrics via prometheus

port: 9901 and path: /stats/prometheus.

about the features Upbound offers for collecting telemetry from control planes.


## Router metrics reference {#router-ref}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can likely uncomment these now:

<!-- Track these critical Envoy metrics for the spaces-router: -->

or maybe add some of those details here and link to them? I do like the focused set of metrics we call out on that page, with the bit of adding context.

users can get to those via space-level telemetry now in 1.15 (and by scraping them directly even in previous spaces versions)

@tr0njavolta tr0njavolta merged commit be9d08c into main Nov 20, 2025
3 checks passed
@tr0njavolta tr0njavolta deleted the new-self-hosted-metrics branch December 8, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants