Skip to content

Conversation

@JustusBraun
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds compilation instructions and CMake configuration changes to support building the MeshMPPI package on Ubuntu 22 with ROS2 Humble, which ships with an older GCC version that lacks full C++23 support.

Key Changes:

  • Added CMake version check for CMP0135 policy to avoid errors on older CMake versions
  • Added GCC version validation requiring GCC 13+ for proper C++23 support
  • Included detailed instructions in README for installing GCC 13 on Ubuntu 22

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
mesh_mppi/CMakeLists.txt Adds conditional CMake policy setting, default Release build type, and GCC version enforcement to ensure C++23 compatibility
README.md Adds collapsible section with Ubuntu 22/ROS2 Humble compilation instructions including GCC 13 installation steps

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Co-authored-by: Copilot <[email protected]>
@JustusBraun JustusBraun merged commit 065eef9 into main Nov 26, 2025
1 check passed
@JustusBraun JustusBraun deleted the fix/humble-compile branch November 26, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant