Ensure Temporary Files (input_embeddings.pt or output_embeddings.pt) Are Saved in Relative Directory #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies how temporary files (e.g., input_embeddings.pt and output_embeddings.pt) are stored, addressing the issue mentioned in #905. Specifically, it ensures that these files are saved in a relative directory (_unsloth_temporary_saved_buffers) based on the basename of model.config._name_or_path when it is an absolute path.
This issue has been a challenge for me because the model paths on my server are read-only, and modifications to the original directory were not feasible.
Let me know if there’s anything else to improve!