Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NumberField): always updateModelValue on blur #954

Merged
merged 2 commits into from
May 25, 2024
Merged

fix(NumberField): always updateModelValue on blur #954

merged 2 commits into from
May 25, 2024

Conversation

epr3
Copy link
Collaborator

@epr3 epr3 commented May 25, 2024

Hello,

This PR fixes the issue described in #953 on the NumberField.

It should now start from the min value or 0 on increment/decrement if the input value is cleared.

@epr3 epr3 mentioned this pull request May 25, 2024
Closed
@zernonia zernonia linked an issue May 25, 2024 that may be closed by this pull request
[Bug]: Number Field value remains after deleting field value #953
Closed
zernonia
zernonia approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @epr3 !

@zernonia zernonia merged commit 745fcef into unovue:main May 25, 2024
4 checks passed
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 25, 2024

Last Commit Build: 2463291

radix-vue(2463291):

npm i https://pkg.pr.new/radix-vue@2463291

Pull Request Build: #954

radix-vue(#954):

npm i https://pkg.pr.new/radix-vue@954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zernonia zernonia zernonia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Number Field value remains after deleting field value
2 participants
@epr3 @zernonia