docs(Editable): add Change only on submit example
#1538
Conversation
| <template> | ||
| <template> | ||
| <EditableRoot | ||
| :default-value="defaultValue" |
There was a problem hiding this comment.
how about using :model-value instead of default-value? 🤔
There was a problem hiding this comment.
this will not work, I think because of useVModel inside Editable, we don't make copy to have ability to edit it, refer to stackblitz and video examples 🙌
Stackblitz: https://stackblitz.com/edit/adsgveqt?file=src%2FApp.vue
Video:
radix-editable-bug.mp4
There was a problem hiding this comment.
Thanks @hrynevychroman ! I understand the challenge here now. Looking at the example made me realized this might be a pattern that is quite unintuitive.
I would like to refactor EditableInput to only update modelValue when we commit it, this inline with the NumberFieldInput's behavior. So when user commit the changes, it updates v-model, if cancel, nothing happened. I believe this is something you are looking for right?
WDYT?
There was a problem hiding this comment.
@zernonia Yeah, this is something I'm looking for, I will take a look and open a PR when I have some free time, probably this Saturday 🙌
hrynevychroman
force-pushed
the
docs/editable-example
branch
from
0687e1b to
e14f035
Compare
I have faced some issues with understanding how to make a field editable and not change
v-modelwhen editing and found this example in the Histoire files of the project, I think that this would be useful for others 😉