Upgrade to v9 test (#418)

* Upgrade to v9 test * Finish * Update lint-pr.yml --------- Co-authored-by: Geovanni Perez <[email protected]>
unosquare · Apr 24, 2024 · 1ed9aed · 1ed9aed
1 parent 6084371
commit 1ed9aed
Show file tree

Hide file tree

Showing 9 changed files with 545 additions and 734 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
diff --git a/.github/workflows/lint-pr.yml b/.github/workflows/lint-pr.yml
@@ -6,6 +6,6 @@ on:
 
 jobs:
   build:    
-    uses: unosquare/bump-npm-version/.github/workflows/lint.yml@master
+    uses: unosquare/bump-npm-version/.github/workflows/lint-pnpm.yml@master
     secrets:
-      github-token: ${{ secrets.GPR_ACCESS_TOKEN }}
+      github-token: ${{ secrets.GPR_ACCESS_TOKEN }}
diff --git a/eslint.config.js b/eslint.config.js
@@ -0,0 +1,17 @@
+// @ts-check
+
+import eslint from '@eslint/js';
+import tseslint from 'typescript-eslint';
+
+export default tseslint.config(
+    eslint.configs.recommended,
+    ...tseslint.configs.recommended,
+    ...tseslint.configs.stylistic,
+    {
+        files: ['src/*.ts'],
+        rules: {
+            '@typescript-eslint/consistent-type-definitions': 'off',
+            'arrow-body-style': ['error', 'as-needed'],
+        },
+    },
+);
diff --git a/package.json b/package.json
@@ -3,6 +3,7 @@
   "version": "3.94.0",
   "description": "JS/TS common used functions, zero dependencies",
   "main": "dist/index.js",
+  "type": "module",
   "scripts": {
     "test": "jest --runInBand",
     "cest": "jest --collectCoverage --runInBand",
@@ -69,15 +70,13 @@
   },
   "homepage": "https://github.com/unosquare/uno-js#readme",
   "devDependencies": {
+    "@eslint/js": "^9.1.1",
     "@types/jest": "^29.5.12",
-    "@typescript-eslint/eslint-plugin": "^7.7.0",
-    "eslint": "^9.1.0",
-    "eslint-plugin-prettier": "^5.1.3",
-    "eslint-config-prettier": "^9.1.0",
+    "eslint": "^9.1.1",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",
-    "prettier": "^3.2.5",
     "ts-jest": "^29.1.2",
-    "typescript": "^5.4.5"
+    "typescript": "^5.4.5",
+    "typescript-eslint": "^7.7.1"
   }
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/SimpleObservable.ts b/src/SimpleObservable.ts
@@ -1,5 +1,5 @@
 export default class {
-    private readonly observers: Array<(change?: string) => void> = [];
+    private readonly observers: ((change?: string) => void)[] = [];
 
     public subscribe(observer: (change?: string) => void): () => void {
         this.observers.push(observer);

diff --git a/src/createCsv.ts b/src/createCsv.ts
@@ -1,4 +1,4 @@
-type csvRow = string | Array<string>;
+type csvRow = string | string[];
 
 const escapeValuesWithQuotes = (str: string): string =>
     str.match(/\$-?(\d{1,3},+)?(\d{1,3},\d{3}(\.\d)*)/g) ? str.replace(/,\$/g, '","$') : str.replace(/,/g, '","');

diff --git a/src/debounce.ts b/src/debounce.ts
@@ -4,7 +4,6 @@ export type Procedure = (...args: unknown[]) => void;
 export function debounce<F extends Procedure>(func: F, waitMilliseconds = 500): F {
     let timeoutId: number | undefined;
 
-    // tslint:disable-next-line: only-arrow-functions
     return function (t: unknown, ...args: unknown[]) {
         const context = t;
 

diff --git a/src/trimText.ts b/src/trimText.ts
@@ -1,4 +1,4 @@
-export default (text: string | Array<string>) =>
+export default (text: string | string[]) =>
     text.constructor === Array
         ? text
               .map((x: string, i: number) => (i === 0 ? x : ` ${x}`))