fix: ios navbar lifecycle #1331
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1331.eastus2.azurestaticapps.net |
...s/Uno.Toolkit.Samples.Shared/Content/NestedSamples/FluentNavigationBarSampleNestedPage2.xaml
Show resolved
Hide resolved
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1331.eastus2.azurestaticapps.net |
src/Uno.Toolkit.UITest/Controls/NavigationBar/Given_NavigationBar.cs
Outdated
Show resolved
Hide resolved
src/Uno.Toolkit.UITest/Controls/NavigationBar/Given_NavigationBar.cs
Outdated
Show resolved
Hide resolved
| App.WaitForElement("FluentPage3NavBar", "Timed out waiting for Page 3 Nav Bar"); | ||
|
|
||
| PlatformHelpers.On( | ||
| iOS: () => App.Tap(q => q.Marked("FluentPage3NavBar").Descendant("AppCompatImageButton")), |
There was a problem hiding this comment.
This won't work, the AppCompatImageButton is an Android specific type that is used natively.
There was a problem hiding this comment.
If it's not as simple on iOS to drill into the native classes then we can use explicit MainCommands for now
There was a problem hiding this comment.
I can't really debug this on iOS so I'm not sure what native type I should be getting. I removed this test case for now
|
|
rajamatt
force-pushed
the
dev/mara/fix-ios-navbar
branch
from
cb07916 to
54bd5be
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1331.eastus2.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1331.eastus2.azurestaticapps.net |
|
|
GitHub Issue (If applicable): closes #1334
PR Type
What kind of change does this PR introduce?
What is the current behavior?
iOS NavigationBar lifecycle wasn't handled correctly since on iOS the NavBar is always UnLoaded by default when navigating away.
What is the new behavior?
Added OnLoaded for both iOS and Android
NavigationBarPresenterPR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):