Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always generate extension #327

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ajpinedam
Copy link
Contributor

Fixes: #289

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@ajpinedam ajpinedam requested a review from jeromelaban January 17, 2025 14:41
@ajpinedam ajpinedam self-assigned this Jan 17, 2025
@ajpinedam ajpinedam force-pushed the dev/ajpm/always.generate.extension branch from a229122 to afa0e5a Compare January 17, 2025 15:08
@ajpinedam
Copy link
Contributor Author

@jeromelaban this is the PR I mentioned earlier today. Windows Target does not see the generated extension.

@ajpinedam ajpinedam force-pushed the dev/ajpm/always.generate.extension branch from 2a3a682 to 52496ab Compare February 4, 2025 22:28
@ajpinedam ajpinedam marked this pull request as ready for review February 6, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Uno.Resizetizer extension for icon should be conditionally generated
1 participant