feat(raw): Replaced Buffer serializer to improve portability #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The netlify tests seem to be very flaky and slow, we should probably disable them (95% of them ran into timeout on my machine) until the driver is fixed or a faster way of testing is found. |
|
How would this translate to getItemRaw with the web streams? Would it still be possible for the response of the image to be automatically rendered correctly as an image on the browser? |
manniL
reviewed
May 1, 2024
| return genBytesFromBase64(value.slice(BASE64_PREFIX.length)); | ||
| } | ||
|
|
||
| // Base64 utilities - Waiting for https://github.com/unjs/knitwork/pull/83 // TODO: Replace with knitwork imports as soon as PR is merged |
There was a problem hiding this comment.
Yes indeed. The feature is not releaed yet and I ned to complete node {Buffer} support but we shall adopt undio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#142
❓ Type of change
📚 Description
Replaced Buffer with native implementation to also run on workers and other environments. It's also faster than Buffer, but in the context of unstorage, the improvement is not significant.
📝 Checklist