feat: support bun plugin
#333
Draft
+415
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we can't run tests using the Alternatively, we can put the bun test cases in a separate directory rewrite the bun-related test cases with |
so1ve
reviewed
Oct 3, 2023
| meta.build = build | ||
| const { onResolve, onLoad, config: initialOptions } = build | ||
|
|
||
| const onResolveFilter = plugin.esbuild?.onResolveFilter ?? /.*/ |
There was a problem hiding this comment.
Suggested change
| const onResolveFilter = plugin.esbuild?.onResolveFilter ?? /.*/ | |
| const onResolveFilter = plugin.bun?.onResolveFilter ?? /.*/ |
so1ve
reviewed
Oct 3, 2023
| const { onResolve, onLoad, config: initialOptions } = build | ||
|
|
||
| const onResolveFilter = plugin.esbuild?.onResolveFilter ?? /.*/ | ||
| const onLoadFilter = plugin.esbuild?.onLoadFilter ?? /.*/ |
There was a problem hiding this comment.
Suggested change
| const onLoadFilter = plugin.esbuild?.onLoadFilter ?? /.*/ | |
| const onLoadFilter = plugin.bun?.onLoadFilter ?? /.*/ |
so1ve
reviewed
Oct 3, 2023
| } | ||
|
|
||
| // `load` and `transform` may return a sourcemap without toString and toUrl, | ||
| // but esbuild needs them, we fix the two methods |
There was a problem hiding this comment.
Suggested change
| // but esbuild needs them, we fix the two methods | |
| // but bun needs them, we fix the two methods |
sxzz
force-pushed
the
main
branch
4 times, most recently
from
e01729c to
af3b0ec
Compare
sxzz
force-pushed
the
main
branch
2 times, most recently
from
8ba3416 to
6fb5709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
close: #329
❓ Type of change
📚 Description
📝 Checklist